Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=697836 Volker FrÃhlich <volker27@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |volker27@xxxxxx --- Comment #1 from Volker FrÃhlich <volker27@xxxxxx> 2011-05-06 18:44:39 EDT --- Just some comments: Please include the license file. The postal addresses of the FSF are outdated in several files. Use -p on the install commands, at least for the scripts. One of the scripts uses the samtools binary, so you'll need an explicit Require on that, as RPM will only install samtools-libs Besides the first part of the package description is pretty generic, it says, it would contain instructions. I can't see any and especially the mmseq binary is especially sparse on saying anything. Why does the description not have the word "Haplotype"? Why did you choose to not install the Perl script? You might want to add "-b .name_of_the_patch" to the patch macros. Please also comment on the patches. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review