Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=675104 --- Comment #5 from Pavel Zhukov <pavel@xxxxxxxxxxx> 2011-02-05 09:06:22 EST --- Upstream sources has *py in its name. It's ok rpmlint output is clean. It's ok -- Please remove %clean section because F12 is currently unsupported or add BuildRoot tag if you want build package for EPEL -- Please add python2-devel if you package for Python2 only, python3-devel if you package for Python3 only. A package that has both python2 and python3 files will need to BuildRequire both. Please see http://fedoraproject.org/wiki/Packaging:Python#BuildRequires -- Please remove python from BuildRequires because python-devel already has python in deplist -- Each source file contains point to LICENSE but there is not LICENSE file. So you SHOULD query upstream to include it.See http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text for additional info -- There's also no need to use %{__rm} for rm command, although there is currently no guideline forbidding it. Please replace pointless macros or give reasons to use it. -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review