Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=674188 Michael Schwendt <mschwendt@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mschwendt@xxxxxxxxx --- Comment #2 from Michael Schwendt <mschwendt@xxxxxxxxx> 2011-02-05 08:56:19 EST --- This needs some more work, not limited to these issues or those found by Thomas already: Run rpmlint not just on the src.rpm, but also on the built rpms. > #BuildRequires: > Requires: zeitgeist https://fedoraproject.org/wiki/Packaging:Guidelines#Explicit_Requires This explicit Requires asks for a comment in the spec file. Is it a run-time dependency only? Is it an install-time dependency? > %{_libdir}/pkgconfig You include the directory, which belongs into the pkgconfig package. To fix this, specify the exact .pc file name to include in your package: %{_libdir}/pkgconfig/zeitgeist-1.0.pc That would also help with noticing updates/upgrades which bump the version in that file name and would break compatibility with dependencies that look for exactly that .pc file. > %doc %{_docdir}/%{name} This is duplicated in both packages. Additionally, the HTML docs are duplicated, too, in several places. > %docdir %{_datadir}/gtk-doc/html/zeitgeist-1.0 What does this do? It doesn't mark any directory as %doc, and a few lines below you include the directory once more: %doc %{_datadir}/gtk-doc/html/zeitgeist-1.0 > %doc AUTHORS ChangeLog COPYING COPYING.GPL INSTALL MAINTAINERS NEWS README > %doc %{_docdir}/%{name} That creates duplicates, too. Plus, the INSTALL file is the one that is irrelevant to RPM package users: $ rpm -qpd libzeitgeist-0.3.2-1.fc14.i686.rpm /usr/share/doc/libzeitgeist-0.3.2/AUTHORS /usr/share/doc/libzeitgeist-0.3.2/COPYING /usr/share/doc/libzeitgeist-0.3.2/COPYING.GPL /usr/share/doc/libzeitgeist-0.3.2/ChangeLog /usr/share/doc/libzeitgeist-0.3.2/INSTALL /usr/share/doc/libzeitgeist-0.3.2/MAINTAINERS /usr/share/doc/libzeitgeist-0.3.2/NEWS /usr/share/doc/libzeitgeist-0.3.2/README /usr/share/doc/libzeitgeist/AUTHORS /usr/share/doc/libzeitgeist/COPYING /usr/share/doc/libzeitgeist/INSTALL /usr/share/doc/libzeitgeist/MAINTAINERS /usr/share/doc/libzeitgeist/README > %{_datadir}/vala/vapi As a general hint on including directories, consider adding a trailing slash for increased readability and clearness: %{_datadir}/vala/vapi/ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review