Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=675104 --- Comment #6 from Ratnadeep Debnath <rtnpro@xxxxxxxxx> 2011-02-05 11:06:09 EST --- (In reply to comment #5) > -- Please remove %clean section because F12 is currently unsupported or add > BuildRoot tag if you want build package for EPEL Currently, I am packaging it only for Fedora. If it is error-free, I will package it for EPEL. > -- Please add python2-devel if you package for Python2 only, python3-devel if > you package for Python3 only. A package that has both python2 and python3 files > will need to BuildRequire both. > Please see http://fedoraproject.org/wiki/Packaging:Python#BuildRequires As far as I know, python2-devel doesn't exist in yum repository, there exists python-devel ( for python2) and python3-devel. > -- Please remove python from BuildRequires because python-devel already has > python in deplist done. > -- Each source file contains point to LICENSE but there is not LICENSE file. So > you SHOULD query upstream to include it.See > http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text for > additional info There is a LICENSE file in the root of the src dir. > -- There's also no need to use %{__rm} for rm command, although there is > currently no guideline forbidding it. Do I remove the %{__rm} macro from %install section also? > Please replace pointless macros or give > reasons to use it. Please mention the pointless macros. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review