Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=674674 --- Comment #3 from Robin Lee <robinlee.sysu@xxxxxxxxx> 2011-02-03 00:48:12 EST --- (In reply to comment #2) > (In reply to comment #1) > > [-] MUST: All build dependencies must be listed in BuildRequires > > * According to setup.py, python-zope-testing is required to run the tests. > > Yep, it already pulls this in. Oh, sorry, this is my miss. > > [=] Buildroot, %clean section and the rm command in %install section are not > > required. > > http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag > > http://fedoraproject.org/wiki/Packaging/Guidelines#.25clean > > I'd rather leave these in at the moment, since I plan on building these down to > EL-5 Then manual definition of %{python_sitelib} is also required: %{!?python_sitelib: %global python_sitelib %(%{__python} -c "from distutils.sysconfig import get_python_lib; print(get_python_lib())")} > > > [=] Doctest text files in %{python_sitelib}/zope/configuration/ should be > > excluded. > > [=] Consider excluding the tests > > /usr/lib/python2.7/site-packages/zope/configuration/tests > > I now delete these after we run the test suite in %check. > > Updated spec and SRPM here: > http://lmacken.fedorapeople.org/rpms/python-zope-configuration.spec > http://lmacken.fedorapeople.org/rpms/python-zope-configuration-3.7.2-1.fc13.src.rpm [-] python-setuptools is not required in runtime. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review