Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=674674 --- Comment #2 from Luke Macken <lmacken@xxxxxxxxxx> 2011-02-03 00:03:31 EST --- (In reply to comment #1) > [-] MUST: All build dependencies must be listed in BuildRequires > * According to setup.py, python-zope-testing is required to run the tests. Yep, it already pulls this in. > [=] MUST: Packages must not own files or directories already owned by other > packages. > * This package may not own %{python_sitelib}/zope/ , which already provided by > its dependence. Fixed. > [=] Consider including CHANGES.txt COPYRIGHT.txt > [=] Consider renaming python-setuptools-devel to python-setuptools > [-] Source0 URL: > http://pypi.python.org/packages/source/z/%{modname}/%{modname}-%{version}.zip Fixed. > [=] Buildroot, %clean section and the rm command in %install section are not > required. > http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag > http://fedoraproject.org/wiki/Packaging/Guidelines#.25clean I'd rather leave these in at the moment, since I plan on building these down to EL-5 > [=] Doctest text files in %{python_sitelib}/zope/configuration/ should be > excluded. > [=] Consider excluding the tests > /usr/lib/python2.7/site-packages/zope/configuration/tests I now delete these after we run the test suite in %check. Updated spec and SRPM here: http://lmacken.fedorapeople.org/rpms/python-zope-configuration.spec http://lmacken.fedorapeople.org/rpms/python-zope-configuration-3.7.2-1.fc13.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review