Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=674674 Luke Macken <lmacken@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |needinfo?(robinlee.sysu@gma | |il.com) --- Comment #4 from Luke Macken <lmacken@xxxxxxxxxx> 2011-02-03 08:58:44 EST --- (In reply to comment #3) > > > [=] Buildroot, %clean section and the rm command in %install section are not > > > required. > > > http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag > > > http://fedoraproject.org/wiki/Packaging/Guidelines#.25clean > > > > I'd rather leave these in at the moment, since I plan on building these down to > > EL-5 > Then manual definition of %{python_sitelib} is also required: > %{!?python_sitelib: %global python_sitelib %(%{__python} -c "from > distutils.sysconfig import get_python_lib; print(get_python_lib())")} Added. > [-] python-setuptools is not required in runtime. Removed. Updated the SRPM & SPEC with the same URL as before. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review