Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=668098 Mohammed Morsi <mmorsi@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #3 from Mohammed Morsi <mmorsi@xxxxxxxxxx> 2011-01-24 15:59:36 EST --- To run the test suite, simply add the following to the spec %check pushd %{buildroot}%{geminstdir} rake test You will also need to add "BuildRequires: rubygem(rake)" Up to you though, this is not required for approval, and I've verified the test suite works against this rpm in any case. The package looks to be Fedora compliant overall minus one nit, please remove the "rm -rf %{buildroot}" in the %install section. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review