Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=668098 Mohammed Morsi <mmorsi@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |mmorsi@xxxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |mmorsi@xxxxxxxxxx Flag| |fedora-review? --- Comment #2 from Mohammed Morsi <mmorsi@xxxxxxxxxx> 2011-01-18 21:46:04 EST --- Looks mostly good. The only comment I would say is if you could include a %check section and run 'rake test' in it. You will have to add a BuildRequies(check) for rubygem(rake) rpmlint looks good, koji looks good -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review