Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=668098 --- Comment #4 from Minnikhanov <minnikhanov@xxxxxxxxx> 2011-01-25 15:07:08 EST --- Spec URL: http://dl.dropbox.com/u/14118661/rubygem-tzinfo.spec SRPM URL: http://dl.dropbox.com/u/14118661/rubygem-tzinfo-0.3.24-2.fc14.src.rpm koji scratch build successful: http://koji.fedoraproject.org/koji/taskinfo?taskID=2729534 Test pass. (In reply to comment #3) > To run the test suite, simply add the following to the spec > > %check > pushd %{buildroot}%{geminstdir} > rake test > > You will also need to add "BuildRequires: rubygem(rake)" + Fixed. > The package looks to be Fedora compliant overall minus one nit, please remove > the "rm -rf %{buildroot}" in the %install section. + Fixed. > > APPROVED I am very thankful for collaboration. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review