Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=591389 Christoph Wickert <cwickert@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #7 from Christoph Wickert <cwickert@xxxxxxxxxxxxxxxxx> 2010-10-30 18:09:15 EDT --- I am a little confused. Who is submitting this package and who is reviewing it? It's nice that Oron helps out, but IMHO the reviewer should not work on the package (and contrariwise). (In reply to comment #5) > New SPEC (Release: 4%dist): > http://oron.fedorapeople.org/deb-package/po-debconf.spec > New SRPM: > http://oron.fedorapeople.org/deb-package/po-debconf-1.0.16-4.fc13.src.rpm > > Fixes and cleanups: > 1. Non-specific License: GPL -> GPLv2 If no version is specified, this usually means that "any later version" is included, see paragraph 9 of the GPLv2. > * Installation: was left outside of Makefile 'install' since debian > (rightfully) use their dh_installman (no common code with Fedora) > * Installation from .spec file was fixed: > - Strip the language code from the file basename (foo.1 not foo.de.1) > - Generalize so all man sections are installed, not only section 1 Well done! > TODO: > - Apply %find_lang logic? Yes please > - Send Makefile patch upstream +1 > - Anything else? I'd like to see the HTML docs included, but the rest looks good to me from a quick glance. (In reply to comment #6) > Results of rpmlint for package in comment 5: > po-debconf.src: W: spelling-error Summary(en_US) gettext -> get text, get-text, > getter > po-debconf.src: W: spelling-error %description -l en_US utils -> utile, > utilizes, utilize > po-debconf.src: W: spelling-error %description -l en_US gettext -> get text, > get-text, getter > po-debconf.noarch: W: spelling-error %description -l en_US utils -> utile, > utilizes, utilize > 2 packages and 1 specfiles checked; 0 errors, 4 warnings. These can be ignored. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review