Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=591389 --- Comment #5 from Oron Peled <oron@xxxxxxxxxxxx> 2010-10-25 20:55:24 EDT --- New SPEC (Release: 4%dist): http://oron.fedorapeople.org/deb-package/po-debconf.spec New SRPM: http://oron.fedorapeople.org/deb-package/po-debconf-1.0.16-4.fc13.src.rpm Fixes and cleanups: 1. Non-specific License: GPL -> GPLv2 2. Replaced po-debconf-1.0.16-fix-prefix.patch with a bigger po-debconf-1.0.16-make-install.patch: * prefix appeared more than once (although the second time looked unused) * Added 'install' rule: - Refactored from debian/rules and our .spec file - Use the common DESTDIR= - Define and use common installation directories (prefix, bindir, datadir, etc.) - This should be pushed to upstream (Debian) so logic isn't duplicated. If they apply this, they can (optionally) streamline their debian/rules [and then it may become good candidate for dh(1)] 3. Man pages: * Installation: was left outside of Makefile 'install' since debian (rightfully) use their dh_installman (no common code with Fedora) * Installation from .spec file was fixed: - Strip the language code from the file basename (foo.1 not foo.de.1) - Generalize so all man sections are installed, not only section 1 TODO: - Apply %find_lang logic? - Send Makefile patch upstream - Anything else? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review