[Bug 217239] Review Request: arrows - Neat little maze game

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: arrows - Neat little maze game
Alias: arrows

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=217239





------- Additional Comments From j.w.r.degoede@xxxxxx  2006-11-25 15:37 EST -------
(In reply to comment #1)
> ==== MUST FIX ====
> - Shouldn't this require some package to get the icon dir?  If not, please tell
> me how I determine which Requires would pull this in.  Perhaps Require:
> gnome-icon-theme?  Or hicolor-icon-theme if you decide to move this out of the
> GNOME menu (see SHOULD FIX section).
> 

Yes it should have a "Requires: hicolor-icon-theme", my bad , fixed.

> ==== SHOULD FIX ====
> - I'm not sure I agree all games compiled with gtk2 should be placed under
> GNOME->Games.  I think GNOME->Games should be for games that are distributed
> with GNOME much like KDE has their kde-games package.  This may require further
> discussion on the fedora-games-list.  Not a blocker.

I took that GNOME entry in the .desktop over from the package on which I based
mine, but I agree it isn't a gnome app, dropped.

New version here:
Spec URL: http://people.atrpms.net/~hdegoede/arrows.spec
SRPM URL: http://people.atrpms.net/~hdegoede/arrows-0.6-2.fc7.src.rpm


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]