Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: glest-data - Data files for the game Glest Alias: glest-data https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=216131 ------- Additional Comments From chris.stone@xxxxxxxxx 2006-11-25 15:51 EST ------- ==== REVIEW CHECKLIST ==== - rpmlint output: W: glest-data strange-permission glest-get-translations.sh 0775 W: glest-data no-%build-section You should add a %build with a comment explaining it is not needed Change permissions of SOURCE1 to 755 Explain why you do not install SOURCE1 - package named according to package naming guidelines - spec filename matches %{name} - package meets packaging guidelines - package licensed with open source compatible license X license does not match actual license This is confusing, it looks like the data has a seperate license which just says its distributable, can you clarify this with upstream? I'm not sure this qualifies as being open source compatible. - license included in %doc - spec written in American english - spec legible - source matches upstream 8b6902e82874011e768c64e20fbeead5 glest_data_2.0.0.zip - package successfully compiles and builds on FC6 x86_64 - all build dependencies listed in BR - no locales - no shared libraries - package is not relocatable - package owns all directories it creates - all other directories it uses are provided by Requries - no duplicates in %files - file permissions set properly - package contains proper %clean section - macro usage is consistent - contains permissible content - no large documentation - files in %doc do not affect runtime - no header files or static libraries - no pkgconfig files - no need for a devel subpackage - no .la files - not a GUI app needed a .desktop file - package does not own files or directories owned by other packages ==== MUST FIX ==== - Why do you include SOURCE1 (glest-get-translations.sh) but do not install it? - Change permissions on SOURCE1 to 755 - Add empty %build with a comment saying nothing to build - data looks like it is not licensed as GPL. Please clarify with upstream - add punctuation to description -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review