Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: arrows - Neat little maze game Alias: arrows https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=217239 ------- Additional Comments From chris.stone@xxxxxxxxx 2006-11-25 12:41 EST ------- ==== REVIEW CHECKLIST ==== - rpmlint output clean - package named according to package naming guidelines - spec filename matches %{name} - package meets Packaging Guidelines - package licensed with open source compatible license - license matches actual license - license file included in %doc - spec written in American english - spec is legible - sources match upstream d6cf52ff319c295b9fb6982c023ec7f0 arrows-0.6.tar.gz - successfully compiles and builds on FC6 x86_64 - all build dependencies listed in BR - no locales - no shared libraries - package is not relocatable - package owns all directories it creates X package uses a directory it doesnt create and I cannot determine if its pulled in from Requires packages. This package puts an icon in /usr/share/icons/hicolor/24x24/apps/ - no duplicates in %files - file permissions set properly - package contains proper %clean - macro usage consistent - contains code - no large documentation - %doc does not affect runtime - no header files or static libraries - no pkgconfig files - no devel subpackage required - no .la files O desktop file installed properly (although see my comment in SHOULD fix) - package does not own files or directories owned by other packages ==== MUST FIX ==== - Shouldn't this require some package to get the icon dir? If not, please tell me how I determine which Requires would pull this in. Perhaps Require: gnome-icon-theme? Or hicolor-icon-theme if you decide to move this out of the GNOME menu (see SHOULD FIX section). ==== SHOULD FIX ==== - I'm not sure I agree all games compiled with gtk2 should be placed under GNOME->Games. I think GNOME->Games should be for games that are distributed with GNOME much like KDE has their kde-games package. This may require further discussion on the fedora-games-list. Not a blocker. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review