Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=626004 Martin Gieseking <martin.gieseking@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.gieseking@xxxxxx --- Comment #2 from Martin Gieseking <martin.gieseking@xxxxxx> 2010-09-04 07:42:05 EDT --- (In reply to comment #1) > - The sources show (configure.ac) osm2pgsql claims to be at Version 0.69 - this > is also reported by the program itself. Good catch. I agree that the Version field should reflect the complete version of the utility. > Release: 1.1.%{svn_ver}svn%{?dist} to keep version numbers monotone. Since there's no officially released source tarball on the upstream website, this package is considered a "snapshot release". Such packages must follow the numbering scheme described at http://fedoraproject.org/wiki/PackageNamingGuidelines#PreReleasePackages Thus, the current Release tag is OK. > configure: WARNING: unrecognized options: --disable-dependency-tracking > and: > osm2pgsql.c: In function 'main': > osm2pgsql.c:818:28: warning: assignment from incompatible pointer type These seem to be minor issues that don't affect the functionality of the program. However, they should of course be investigated by the upstream developer. Here are some more comments on the spec file: - replace %define with %global (see https://fedoraproject.org/wiki/PackagingDrafts/global_preferred_over_define) - you can drop the --prefix option from %configure (--prefix=%{_prefix} is already part of the %configure macro) - I recommend to be more specific in %files as there's only a single manpage to add: %{_mandir}/man1/osm2pgsql.1* -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review