Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=626004 Jon Burgess <jburgess777@xxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jburgess777@xxxxxxxxxxxxxx --- Comment #3 from Jon Burgess <jburgess777@xxxxxxxxxxxxxx> 2010-10-02 10:04:48 EDT --- (In reply to comment #2) > (In reply to comment #1) > > configure: WARNING: unrecognized options: --disable-dependency-tracking > > and: > > osm2pgsql.c: In function 'main': > > osm2pgsql.c:818:28: warning: assignment from incompatible pointer type > > These seem to be minor issues that don't affect the functionality of the > program. However, they should of course be investigated by the upstream > developer. Hi. I'm the main upstream author for osm2pgsql. I just committed a fix for that warning in r23440 of the osm2pgsql SVN code. > - The program is supposed to report its version as %{version}-%{svn_ver}, but > the latter string is empty - that might also be worth fixing and sending > upstream. In the upstream version the Makefile generates this via $(shell svnversion) but the SVN metadata is discarded in the 'svn export' step. How about putting this in the osm2pgsql.spec: make %{?_smp_mflags} SVN=%{svn_ver} This ends up being reported like: $ /usr/bin/osm2pgsql -v osm2pgsql SVN version 0.69-20101002 Alternative you could put %{release} in there. The purpose of this string is to help myself and other developers keep track of which revision/snapshot someone has used, anything which can be tracked back to a specific source version is sufficient. > - As the license is not included as text, the Guidelines suggest pointing > this out to upstream and asking them to correct this mistake. What do you want here, a copy of the GPL COPYING file added into the osm2pgsql SVN tree? I can do that if you want. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review