Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=626004 Ralph Lange <Ralph.Lange@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Ralph.Lange@xxxxxxxx --- Comment #1 from Ralph Lange <Ralph.Lange@xxxxxxxx> 2010-09-03 14:39:07 EDT --- I was having a look at your package, here's the short list of issues that I see: - The sources show (configure.ac) osm2pgsql claims to be at Version 0.69 - this is also reported by the program itself. There's also a .spec.in file (from 2008) in the sources that uses Version 0.69 and Release 1.%{svn_ver}. So maybe consider changing your package version numbers to Version: 0.69 and Release: 1.1.%{svn_ver}svn%{?dist} to keep version numbers monotone. - The mock build shows two warnings that might be worthwhile fixing and/or reporting to upstream: configure: WARNING: unrecognized options: --disable-dependency-tracking and: osm2pgsql.c: In function 'main': osm2pgsql.c:818:28: warning: assignment from incompatible pointer type - The program is supposed to report its version as %{version}-%{svn_ver}, but the latter string is empty - that might also be worth fixing and sending upstream. - As the license is not included as text, the Guidelines suggest pointing this out to upstream and asking them to correct this mistake. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review