Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: flite - Small, fast speech synthesis engine (text-to-speech) https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=207793 ------- Additional Comments From pertusus@xxxxxxx 2006-11-13 07:49 EST ------- (In reply to comment #21) > - I don't think patching to configure (not configure.in) is > preferable. Would you rewrite sharedlibs.patch and spec > file so that the patch is applied for configure.in and > then 'autoconf' is called (this requires 'autoconf' for > BuildRequires)? Actually I think that the reverse is true. Avoiding to rerun the autotools is better, so patching configure is better. It may be right to patch both configure and configure.in especially if the configure.in is interesting for submission upstream. Sometimes the patch is too important, so patching configure is necessary. Here the configure patch has allready been done with newer autoconf than what came with flite, but I think that we shouldd refrain from using an even newer version of autotools and the patch should be kept as is. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review