Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: flite - Small, fast speech synthesis engine (text-to-speech) https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=207793 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2006-11-13 07:32 EST ------- Well, almost okay. 1. From http://fedoraproject.org/wiki/Packaging/Guidelines : * Filesystem Layout - I think all header files in -devel package should be moved to %{_includedir}/%{name} (then %{_includedir}/%{name} should be owned). * Timestamps cp %{SOURCE1} . Use 'cp -p' to keep timestamps. 2. From http://fedoraproject.org/wiki/Packaging/ReviewGuidelines : = Nothing. 3. Other things I have noticed: * Patches: - Well, the name of the patch and the suffix when applying it are inconsistent..... - I don't think patching to configure (not configure.in) is preferable. Would you rewrite sharedlibs.patch and spec file so that the patch is applied for configure.in and then 'autoconf' is called (this requires 'autoconf' for BuildRequires)? - Note: usually flite-1.3-*****.patch is preferable for the names of the patches. * parallel make - Please add some comments to spec file that "this package fails parallel make". -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review