Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608069 Michael Scherer <misc@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misc@xxxxxxxx --- Comment #1 from Michael Scherer <misc@xxxxxxxx> 2010-06-29 18:00:24 EDT --- First, sorry if I seems to be nitpicking, but that catched my eyes : - the comment about hg is wrong, as you use svn. ( line 4 ) - Summary could be improved, I think it is weird to have a complete sentence there. Same goes for examples subpackage, and some others parts of %description - in %setup, you remove some binary build directory, what is the reason ? If other directories appears there in the futur, should they be removed too ? Maybe they could be removed directly from the tarball ? - can you explain the line about infinite loop in %build ? - the french description could be improved, IMHO. - the buildsystem seems to use directly a binary ( bob ), and they store the binary in svn directly. This seems bad, as we cannot inspect of fix anything. Wouldn't it be better to regenerate the binary using the source and the script ? I think the issue have been discussed in the past on fedora-devel, but I am not sure about the conclusion, so disregard my comment if I was wrong. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review