Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608069 --- Comment #2 from MERCIER Jonathan <bioinfornatics@xxxxxxxxx> 2010-06-29 19:46:18 EDT --- file are updated here: http://bioinfornatics.fedorapeople.org/ (In reply to comment #1) > First, sorry if I seems to be nitpicking, but that catched my eyes : > > - the comment about hg is wrong, as you use svn. ( line 4 ) true, sorry is fixed (In reply to comment #1) > - Summary could be improved, I think it is weird to have a complete sentence > there. Same goes for examples subpackage, and some others parts of %description Done (In reply to comment #1) > - in %setup, you remove some binary build directory, what is the reason ? If this file are never used: - /core/rt/compiler/dmd is for dmd compiler but is not open source - /core/rt/compiler/gdc if for gdc compiler this project are a low activity and is only for d1 revision for this reason i do'nt package it (instead ldc who work on d1 and d2). (In reply to comment #1) > other directories appears there in the futur, should they be removed too ? > Maybe they could be removed directly from the tarball ? will see > - can you explain the line about infinite loop in %build ? i try compil with 03 and 02 optimization but fail > - the french description could be improved, IMHO. Done > - the buildsystem seems to use directly a binary ( bob ), and they store the > binary in svn directly. This seems bad, as we cannot inspect of fix anything. > Wouldn't it be better to regenerate the binary using the source and the script > ? I think the issue have been discussed in the past on fedora-devel, but I am > not sure about the conclusion, so disregard my comment if I was wrong. use ruby script instead binary -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review