[Bug 597307] Review Request: fastx_toolkit - Tools to process short-reads FASTA/FASTQ files

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=597307

--- Comment #3 from Michael Schwendt <mschwendt@xxxxxxxxx> 2010-06-21 05:52:45 EDT ---
> MUST: Optflags are used and time stamps preserved.

Not entirely. The source code overrides Fedora's optflags.


* Description of the -devel subpackage doesn't match its contents:

| The fastx_toolkit-devel package contains libraries and
| header files for developing applications that use fastx_toolkit.

It doesn't contain any libraries and header files.

It contains two M4 macro definition files from the GNU Autoconf Archive. It's
questionable to assign them to this package and place them in the public
aclocal directory.

$ rpmls -p fastx_toolkit-devel-0.0.13-1.fc13.x86_64.rpm|grep local
-rw-r--r--  /usr/share/aclocal/ax_c_long_long.m4
-rw-r--r--  /usr/share/aclocal/ax_cxx_header_stdcxx_tr1.m4

The only other contents of the -devel package is the big tree at:
/usr/share/doc/fastx_toolkit-devel-0.0.13/galaxy

Licensed differently (!).
Lots of unusable Makefile* files.
Icon files, XML files, not really any documentation about all that.
Strange place to dump that into %doc and a -devel pkg.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]