Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=605808 Chen Lei <supercyper1@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |supercyper1@xxxxxxxxx --- Comment #6 from Chen Lei <supercyper1@xxxxxxxxx> 2010-06-21 05:56:23 EDT --- Some issues need further address: 1. BuildRequires: autoconf >= 2.57, pkgconfig are not needed. 2.Mix use of macros %{__make} %{?_smp_mflags} %install %{__rm} -rf %{buildroot} make INSTALL="install -p" CP="cp -p" DESTDIR=%{buildroot} install Use make and rm instead of %{__make} %{__rm} 3.Scriptlet are incompleted. See https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache 4. changelog You need to add a blank line beween changelog entities. 5. desktop file desktop-file install --vendor "" \ --add-category X-Red-Hat-Base \ --dir %{buildroot}%{_datadir}/applications \ %{name}.desktop Why to add X-Red-Hat-Base? Categories=GNOME;Application;AudioVideo; Application is not valid category, please remove it from desktop file. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review