Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=594744 --- Comment #4 from Martin Gieseking <martin.gieseking@xxxxxx> 2010-05-24 14:24:12 EDT --- Thanks for the comments, Chen Lei. I'll update the package in about a week when version 2.3.2 is out. It incorporates the locale patch and fixes the shared-lib-calls-exit issue. (In reply to comment #3) > 1.I suggest you to split shlibs into subpackages, e.g. zint-libs zint-qt-libs. > Fedora ships multilibs in x86_64 and ppc64. Yes, that's a good idea. However, it leads to 6 pretty small packages. If this is not a problem, I'll go with it. > 3. I'll be better to include .desktop as Source1 in spec I prefer keeping the desktop file in the spec. :) It's kind of personal preference, I think. I'll ask upstream to add it to the tarball, though. > 7. > BuildRequires: qt-devel >= 4.4 > BuildRequires: desktop-file-utils > > BR should not be added to subpackages. Is there a hint about this in the guidelines? Technically, there's no difference whether the BRs are placed in the base package or a subpackage. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review