Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=594744 --- Comment #3 from Chen Lei <supercyper1@xxxxxxxxx> 2010-05-24 13:09:02 EDT --- 1.I suggest you to split shlibs into subpackages, e.g. zint-libs zint-qt-libs. Fedora ships multilibs in x86_64 and ppc64. 2.%package -n zint-devel -> %package devel 3. I'll be better to include .desktop as Source1 in spec 4.%cmake CMakeLists.txt -> %cmake . 5.Group: Applications/Engineering is not appropriate 6.For Source field, see http://fedoraproject.org/wiki/Packaging:SourceURL#Sourceforge.net 7. BuildRequires: qt-devel >= 4.4 BuildRequires: desktop-file-utils BR should not be added to subpackages. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review