Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=594744 --- Comment #5 from Chen Lei <supercyper1@xxxxxxxxx> 2010-05-24 21:51:20 EDT --- > > 3. I'll be better to include .desktop as Source1 in spec > I prefer keeping the desktop file in the spec. :) It's kind of personal > preference, I think. I'll ask upstream to add it to the tarball, though. Historically, fedora packaging guideline only accepts including desktop file as a source file. But, recently incluing desktop file in spec is also accepted. > > 7. > > BuildRequires: qt-devel >= 4.4 > > BuildRequires: desktop-file-utils > > > > BR should not be added to subpackages. > Is there a hint about this in the guidelines? Technically, there's no > difference whether the BRs are placed in the base package or a subpackage. Adding BR to subpackages make no sense. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review