Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: evolution-brutus Alias: evolution-brutus https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203520 ------- Additional Comments From colding@xxxxxxxxx 2006-11-01 02:53 EST ------- (In reply to comment #44) > A. > Oh, please don't change the original source tarball without changing > its version!! This will confuse people who use evolution-brutus. OK, I'll just release new versions instead. > B. > I have not yet rebuilt the new srpm you uploaded, however: > I use rawhide, and Fedora Extras packages have to be rebuilt firstly > for rawhide environment as buildsys forces it. > > I have to say that current evolution and evolution-data-server in rawhide is: > [tasaka1@localhost ~]$ rpm -q evolution evolution-data-server > evolution-2.9.1-2.fc7 > evolution-data-server-1.9.1-2.fc7 > > Please adjust your spec file for these versions. > Through a glance look at your spec, > > %dir %{_includedir}/evolution-data-server-1.8/brutus > > This is no longer correct as current (current means rawhide) > evolution-data-server has: /usr/include/evolution-data-server-1.10/ . > Please use %dir %{_includedir}/evolution-data-server-*/brutus to > avoid version changing (also please check if there is some API change or > so). Just one question: All of these version dependancies are detected during a run of autogen.sh and are then used when the spec is created from the spec.in. Should I remove all of this "clever" version detection stuff and just use '*' whereever a version dependent directory shows up? The same goes for my locale file. It has generally been like this: evolution-brutus-VERSION.mo I did this after looking in several spec files, such as the evolution-connector spec. This spec has currently(*): %files -f evolution-exchange-%{evo_major}.lang where evo_major is defined in the top of the spec. There is a lot of hardcoded (via %define) paths in that spec. This must surely be wrong, yes? BTW, the evolution-connector spec does not use find-lang. Is that wrong? Thanks, jules (*) http://cvs.fedora.redhat.com/viewcvs/devel/evolution-connector/evolution-connector.spec?view=markup -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review