Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=588474 --- Comment #15 from Adam Young <ayoung@xxxxxxxxxx> 2010-05-17 10:23:25 EDT --- Much cleaned up from previous reviews: http://github.com/admiyo/MySpecs/blob/c1f91849426aed4747472ebe7291e2209293c786/rubygem-rubyzip.spec http://admiyo.fedorapeople.org/buildr-repo/rubygem-rubyzip-0.9.4-2.young.src.rpm I went back to the 0.9.4 version. It was the latest, it had a lot cleaned up from 0.9.1, and the issue that caused the breakage could be handled by a patch to buildr. The lint errors are fixed. The lint warnings about template strings in the installed files are still there, but that is an artifact of the ruby info build, which has not yet been addressed by the developers. License is back to GPL V2 or Ruby. Permissions are fixed -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review