Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=588474 --- Comment #16 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2010-05-17 13:45:52 EDT --- (From next time, please change the release number when you modify your spec file to avoid confusion). For (second) -2: * rpmlint - non-standard-executable-perm rpmlint errors still exist ------------------------------------------------------------------------- rubygem-rubyzip-doc.noarch: E: non-executable-script /usr/lib/ruby/gems/1.8/gems/rubyzip-0.9.4/test/data/file2.txt 0664L /usr/bin/env rubygem-rubyzip-doc.noarch: E: non-standard-executable-perm /usr/lib/ruby/gems/1.8/gems/rubyzip-0.9.4/test/gentestfiles.rb 0775L rubygem-rubyzip-doc.noarch: E: non-standard-executable-perm /usr/lib/ruby/gems/1.8/gems/rubyzip-0.9.4/test/ziprequiretest.rb 0775L rubygem-rubyzip-doc.noarch: E: non-standard-executable-perm /usr/lib/ruby/gems/1.8/gems/rubyzip-0.9.4/test/stdrubyexttest.rb 0775L rubygem-rubyzip-doc.noarch: E: non-standard-executable-perm /usr/lib/ruby/gems/1.8/gems/rubyzip-0.9.4/test/alltests.rb 0775L rubygem-rubyzip-doc.noarch: E: non-standard-executable-perm /usr/lib/ruby/gems/1.8/gems/rubyzip-0.9.4/test/ioextrastest.rb 0775L rubygem-rubyzip-doc.noarch: E: non-standard-executable-perm /usr/lib/ruby/gems/1.8/gems/rubyzip-0.9.4/test/data/notzippedruby.rb 0775L ------------------------------------------------------------------------- Again, permissions should usually be 0644 or 0755. * license tag - is still "GPLv2+ or Ruby". * Consistent macro usage - Please use %geminstdir when possible (please check %check section) * Test program - Please enable test program (also please check my previous comment) > ! Note > "require 'net/sftp'" line in Rakefile doesn't seem to be needed. * Document files - I guess sample/ directory should be marked as %doc (and are there any reason you want to put sample/ file in main binary rpm?) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review