Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=588474 --- Comment #14 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2010-05-15 14:18:21 EDT --- Well, for -2: * License > * When the source code says the license is "the same as Ruby", > it means "GPLv2 or Ruby" license tag on Fedora. * SourceURL - "Source0: " is written twice for unknown reason. * rpmlint issue - There are still some complaints about "non-executable-script" and "non-standard-executable-perm". ---------------------------------------------------------------- rubygem-rubyzip-doc.noarch: E: non-executable-script /usr/lib/ruby/gems/1.8/gems/rubyzip-0.9.4/test/data/file2.txt 0664L /usr/bin/env rubygem-rubyzip-doc.noarch: E: non-standard-executable-perm /usr/lib/ruby/gems/1.8/gems/rubyzip-0.9.4/test/gentestfiles.rb 0775L rubygem-rubyzip-doc.noarch: E: non-standard-executable-perm /usr/lib/ruby/gems/1.8/gems/rubyzip-0.9.4/test/ziprequiretest.rb 0775L rubygem-rubyzip-doc.noarch: E: non-standard-executable-perm /usr/lib/ruby/gems/1.8/gems/rubyzip-0.9.4/test/stdrubyexttest.rb 0775L rubygem-rubyzip-doc.noarch: E: non-standard-executable-perm /usr/lib/ruby/gems/1.8/gems/rubyzip-0.9.4/test/alltests.rb 0775L rubygem-rubyzip-doc.noarch: E: non-standard-executable-perm /usr/lib/ruby/gems/1.8/gems/rubyzip-0.9.4/test/ioextrastest.rb 0775L rubygem-rubyzip-doc.noarch: E: non-standard-executable-perm /usr/lib/ruby/gems/1.8/gems/rubyzip-0.9.4/test/data/notzippedruby.rb 0775L ---------------------------------------------------------------- - 0775 is unusual, which should be 0755. - scripts with shebags should have 0755 permission. Please change the permission of these scripts in %install explicitly. * Enabling test > * Please enable %check section and execute some test program > there. > ! Note > "require 'net/sftp'" line in Rakefile doesn't seem to be needed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review