Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=579291 --- Comment #2 from Peter Robinson <pbrobinson@xxxxxxxxx> 2010-04-14 06:36:08 EDT --- > 1.change %{buildroot} to $RPM_BUILD_ROOT on line 51 I'll update it to use all %{buildroot} as that's the newer preferred option. Sorry cut'n'paste error. > 2.If the package is intended for EPEL 5 also,I think you need to Requires: > pkgconfig > https://fedoraproject.org/wiki/Packaging/Guidelines#Pkgconfig_Files Nope, it needs clutter 1.2 which isn't in EL at all. It will only be F-13 and later. > 3. not checked functioning. failed to build rpm for f12 Needs clutter 1.2 so it will fail. > 4. rpmlint gives error since devel has no docs here. Isn't something major > here. Nope, its not. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review