Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=580658 --- Comment #2 from Christian Krause <chkr@xxxxxxxxxxx> 2010-04-08 17:50:46 EDT --- Hi Martin, thanks for your comments! (In reply to comment #1) > - the .desktop must be properly installed > (see https://fedoraproject.org/wiki/Packaging/Guidelines#desktop) fixed > - drop INSTALL from %doc as it's not of much use in a binary rpm fixed > - in %files, add a trailing slash to %{_datadir}/nall to indicate that a folder > is added fixed > - in Source0 and %files, replace "nall" with %{name} I have replace one occurence in the %files section, but the main part of the Source0 URL have left as it is. Since the URL and the download directory can more or less arbitrarily chosen by upstream, I don't think that we should use rpm variables here. Sure, for the filename itself it makes sense, because in general we want that filename and package name match. Spec URL: http://chkr.fedorapeople.org/review/nall.spec SRPM URL: http://chkr.fedorapeople.org/review/nall-1.0-2.fc11.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review