Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=580658 Martin Gieseking <martin.gieseking@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.gieseking@xxxxxx --- Comment #1 from Martin Gieseking <martin.gieseking@xxxxxx> 2010-04-08 15:11:07 EDT --- Hi Christian, here are a couple of initial comments: - the .desktop must be properly installed (see https://fedoraproject.org/wiki/Packaging/Guidelines#desktop) - drop INSTALL from %doc as it's not of much use in a binary rpm - in %files, add a trailing slash to %{_datadir}/nall to indicate that a folder is added - in Source0 and %files, replace "nall" with %{name} -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review