Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=580658 Martin Gieseking <martin.gieseking@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |martin.gieseking@xxxxxx Flag| |fedora-review? --- Comment #3 from Martin Gieseking <martin.gieseking@xxxxxx> 2010-04-09 10:22:16 EDT --- Hi Christian, (In reply to comment #2) > I have replace one occurence in the %files section, but the main part of the > Source0 URL have left as it is. Since the URL and the download directory can > more or less arbitrarily chosen by upstream, I don't think that we should use > rpm variables here. OK, that's fine. Here comes the formal review. The package looks pretty clean now. I just suggest another minor enhancement: Although %{_bindir}/* adds the correct file at the moment, using "*" could become a bit dangerous here. It's better to be more restrictive and give the actual name of the added file: %{_bindir}/%{name} $ rpmlint /var/lib/mock/fedora-12-i386/result/*.rpm nall.i686: W: spelling-error %description -l en_US gtk -> gt, gt k, GTE nall.i686: W: spelling-error %description -l en_US freedesktop -> free desktop, free-desktop, desktop nall.i686: W: spelling-error %description -l en_US trayer -> tracer, trader, grayer nall.i686: W: spelling-error %description -l en_US tooltip -> tool tip, tool-tip, toolkit nall.src: W: spelling-error %description -l en_US gtk -> gt, gt k, GTE nall.src: W: spelling-error %description -l en_US freedesktop -> free desktop, free-desktop, desktop nall.src: W: spelling-error %description -l en_US trayer -> tracer, trader, grayer nall.src: W: spelling-error %description -l en_US tooltip -> tool tip, tool-tip, toolkit 3 packages and 0 specfiles checked; 0 errors, 8 warnings. These spelling errors can be ignored. --------------------------------- keys used in following checklist: [+] OK [.] OK, not applicable [X] needs work --------------------------------- [+] MUST: The package must be named according to the Package Naming Guidelines. [+] MUST: The spec file name must match the base package %{name}. [+] MUST: The package must meet the Packaging Guidelines. [+] MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines . [+] MUST: The License field in the package spec file must match the actual license. [+] MUST: The file containing the text of the license(s) for the package must be included in %doc. [+] MUST: The spec file must be written in American English. [+] MUST: The spec file for the package MUST be legible. [+] MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. $ md5sum nall-1.0.tar.gz* e5fb9cb30e40f09a799319cde9fd5de9 nall-1.0.tar.gz e5fb9cb30e40f09a799319cde9fd5de9 nall-1.0.tar.gz.1 [+] MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. koji scratch builds: F-12: http://koji.fedoraproject.org/koji/taskinfo?taskID=2105608 F-13: http://koji.fedoraproject.org/koji/taskinfo?taskID=2105586 [.] MUST: If the package does not successfully compile, build or work on an architecture, ... [+] MUST: All build dependencies must be listed in BuildRequires. [+] MUST: The spec file MUST handle locales properly. [.] MUST: Every binary RPM package (or subpackage) which stores shared library files ... [+] MUST: Packages must NOT bundle copies of system libraries. [.] MUST: If the package is designed to be relocatable, ... [+] MUST: A package must own all directories that it creates. [+] MUST: A Fedora package must not list a file more than once in the spec file's %files listings. [+] MUST: Permissions on files must be set properly. [+] MUST: Each package must consistently use macros. [+] MUST: The package must contain code, or permissable content. [.] MUST: Large documentation files must go in a -doc subpackage. [+] MUST: Files in %doc must not affect the runtime of the application. [.] MUST: Header files must be in a -devel package. [.] MUST: Static libraries must be in a -static package. [.] MUST: .so (without suffix) must go in a -devel package. [.] MUST: devel packages must require the base package [.] MUST: Packages must NOT contain any .la libtool archives. [+] MUST: Packages containing GUI applications must include a %{name}.desktop file [+] MUST: The .desktop file must be properly installed with desktop-file-install in the %install section. [+] MUST: Packages must not own files or directories already owned by other packages. [+] MUST: At the beginning of %install, each package MUST run rm -rf %{buildroot}. [+] MUST: All filenames in rpm packages must be valid UTF-8. [+] SHOULD: The reviewer should test that the package builds in mock. [+] SHOULD: The package should compile and build into binary rpms on all supported architectures. [+] SHOULD: The reviewer should test that the package functions as described. [.] SHOULD: If scriptlets are used, those scriptlets must be sane. [.] SHOULD: Usually, subpackages other than devel should require the base package using a fully versioned dependency. [.] SHOULD: pkgconfig(.pc) files should be placed in a -devel pkg. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review