[Bug 568053] Review Request: 4ti2 - A software package for problems on linear spaces

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=568053

--- Comment #4 from Terje Røsten <terjeros@xxxxxxxxxxxx> 2010-02-25 12:04:39 EST ---

%setup -q

cp %{SOURCE1} .

Add -p to preserve timestamps and remove empty line.

# Compile
make %{?_smp_mflags}

%install

rm -rf %{buildroot}

Remove compile comment and empty line between %install and rm ...


rm -rf %{buildroot}%{_libdir}/*.la
rm -rf %{buildroot}%{_libdir}/*.a

Is these needed?

Remove these:

%post -p /sbin/ldconfig
%postun -p /sbin/ldconfig


%doc COPYING TODO
%doc 4ti2_manual.pdf

all docs on one line?

%{_bindir}/*

Please be more explicit here, much simpler to detect changes.

Update linked spec file when posting changes.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]