Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=567257 --- Comment #5 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2010-02-25 12:04:40 EST --- Well, * License - is GPLv2+ * BR/Requires - ">= 2.16.0" on "BR: gtk2-devel" is not needed because gtk2-devel in currently supported Fedora branches all satisfy this dependency: https://fedoraproject.org/wiki/Packaging/Guidelines#Explicit_Requires - Would you explain why BR: gvfs-devel or R: gvfs is needed? grep'ing gvfs returns nothing. (if gvfs-devel * %description - Please don't repeat the same description on -gtk (note that -gtk subpackage has R: libfm) * Directory ownership issue - Please make it sure that all directories which are newly created by a package which are to be installed newly are correctly owned by the package - Please address the ownership of the following directories --------------------------------------------------------------------- %{_sysconfdir}/xdg/libfm/ %{_libdir}/libfm/ --------------------------------------------------------------------- * -devel/-gtk-devel file splitting - Well, I will say listing files in %_includedir/%name on -devel and -gtk-devel in the current way is error-prone. Would you list files in %_includedir/%name in some automated way like below? --------------------------------------------------------------------- %install .... .... %find_lang %name echo '%%defattr(-,root,root,-)' > base-header.files echo '%%defattr(-,root,root,-)' > gtk-header.files for f in %buildroot%_includedir/%name/*.h do bf=$(basename $f) for dir in base job do if [ -f src/$dir/$bf ] then echo %_includedir/%name/$bf >> base-header.files fi done for dir in gtk do if [ -f src/$dir/$bf ] then echo %_includedir/%name/$bf >> gtk-header.files fi done done %files .... .... %files devel -f base-header.files %defattr(-,root,root,-) %doc TODO %dir %{_includedir}/libfm/ %{_includedir}/libfm/fm.h %{_libdir}/%{name}.so (for .pc file, see below) %files gtk-devel -f gtk-header.files %defattr(-,root,root,-) %{_includedir}/libfm/fm-gtk.h %{_libdir}/%{name}-gtk.so --------------------------------------------------------------------- * pkgconfig .pc file - libfm.pc.in contains --------------------------------------------------------------------- 8 Requires: gtk+-2.0 >= 2.16.0 gthread-2.0 gio-unix-2.0 10 Libs: -L${libdir} -lfm -lfm-gtk --------------------------------------------------------------------- This should defintely not in -devel subpackage (if you want to split -devel and -gtk-devel subpackage). If you want to split -devel and -gtk-devel subpackage, I would propose - that current libfm.pc.in should be renamed to libfm-gtk.pc.in - libfm.pc.in should newly be created which has proper Requires and Libs and this change may be preferable also to the upstream. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review