Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=568053 --- Comment #5 from Mark Chappell <tremble@xxxxxxxxxxxxxx> 2010-02-25 12:32:55 EST --- SRPM URL: http://tremble.fedorapeople.org/packages/4ti2-1.3.2-3.fc12.src.rpm SPEC URL: http://tremble.fedorapeople.org/packages/4ti2.spec > Add -p to preserve timestamps and remove empty line. Done > Remove compile comment and empty line between %install and rm ... Done > rm -rf %{buildroot}%{_libdir}/*.la > rm -rf %{buildroot}%{_libdir}/*.a > > Is these needed? Unfortunately, yes. It builds static libraries, then links its self against them. As it neither distributes the static libraries, nor links staticly against any system libraries I believe this is still acceptable. > Remove these: Done > all docs on one line? Done > %{_bindir}/* > Please be more explicit here, much simpler to detect changes. Done > Update linked spec file when posting changes. Apologies, done this time -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review