Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=555843 Christoph Wickert <cwickert@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|177841(FE-NEEDSPONSOR) | Flag|fedora-review? |fedora-review+ --- Comment #16 from Christoph Wickert <cwickert@xxxxxxxxxxxxxxxxx> 2010-02-22 07:07:00 EST --- All remaining issues are fixed: - Patches have comments and were sent upstream. - %description ends with a dot. - pam_radius.conf is 0600 - location/name of config file is fixed also in INSTALL and the file itself. Some hints however: - You could gather some of the changes and apply them in a single patch, e.g. everything that has to do with the config file. - when you are patching things in a spec, you might want to use -b flag to create backups. This is useful for debugging when a patch cannot be applied. Removing FE-NEEDSPONSOR, the package is APPROVED: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review