Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566964 Terje Røsten <terjeros@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |terjeros@xxxxxxxxxxxx --- Comment #3 from Terje Røsten <terjeros@xxxxxxxxxxxx> 2010-02-22 07:09:43 EST --- A good start Manfred, some updates to assist you: - align tags - < 80 in %desc - drop cd ${RPM_BUILD_DIR}/%{name}-%{version}, it's not needed - change rm -rf $RPM_BUILD_ROOT/* to rm -rf $RPM_BUILD_ROOT - simplify %install - move libspooles.so to -devel - clean up changelog spec: http://terjeros.fedorapeople.org/libspooles/libspooles.spec patch: http://terjeros.fedorapeople.org/libspooles/libspooles.spec.patch If you could do a koji scratch build from srpm that would be nice: https://fedoraproject.org/wiki/Using_the_Koji_build_system#Scratch_builds_2 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review