Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566290 Luya Tshimbalanga <luya@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review+ --- Comment #6 from Luya Tshimbalanga <luya@xxxxxxxxxxxxxxxxx> 2010-02-18 18:58:00 EST --- Further review: + $ md5sum rpmbuild/SOURCES/goddard-backgrounds-12.91.0.tar.lzma Download/goddard-backgrounds-12.91.0.tar.lzma 6db2255dbaf9e5d8609a1fe06b1629ee rpmbuild/SOURCES/goddard-backgrounds-12.91.0.tar.lzma 6db2255dbaf9e5d8609a1fe06b1629ee Download/goddard-backgrounds-12.91.0.tar.lzma + md5sum extracted from srpm files matches md5sum the upstream source + Package succesfully compiled and built into binary rpms with noarch BuildArc + BuidRequires and requires are provided on spec file + No bundled copies of system libraires + Package owns all directories that it created + Files from %file are listed once in spec files + Permission on files are properly set. + Package is a clean section which contains rm -rf $RPM_BUILD_ROOT + Consistent use of macros + Contents are wallpapers under CC-BY-SA created by Fedora Design team + Package runs rm -rf %{buildroot} at the beginning of %install + Filename in rm packages is valid UTF-8 + Source package include license text as separate file + no scriptlets used After thoroughly reviewed both srpm and spec file, goddard-backgrounds fully complies to Fedora Packaging Guideline and set to accept. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review