Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562470 Xavier Bachelot <xavier@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |huzaifas@xxxxxxxxxx, | |xavier@xxxxxxxxxxxx --- Comment #2 from Xavier Bachelot <xavier@xxxxxxxxxxxx> 2010-02-18 19:12:08 EST --- Few comments : - -b 0 in %setup is useless - %{_sysconfdir}/openvas/openvas-client_log.conf should be marked as %config(noreplace) - manfiles should end with .* rather than .gz in case the compression format ever changes. - Missing BuildRequires: desktop-file-utils. See https://fedoraproject.org/wiki/Packaging/Guidelines#desktop - You must not add a vendor tag to the desktop file. Adding Huzaifa to the CC list. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review