Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562469 Xavier Bachelot <xavier@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |huzaifas@xxxxxxxxxx, | |xavier@xxxxxxxxxxxx --- Comment #3 from Xavier Bachelot <xavier@xxxxxxxxxxxx> 2010-02-18 18:59:54 EST --- Few comments : - -b 0 in %setup is useless - $RPM_BUILD_ROOT/%{_sysconfdir}/openvas is created twice - you can save some lines by using "install -Dp ..." rather than "mkdir ...; install -p ..." - some file are packaged twice due to %{_sysconfdir}/openvas in %file. Should be %dir %{_sysconfdir}/openvas. - the logrotate file should be marked as %config(noreplace) - manfiles should end with .* rather than .gz in case the compression format ever changes. Adding Huzaifa to the CC list. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review