Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=561482 --- Comment #2 from Mohammed Morsi <mmorsi@xxxxxxxxxx> 2010-02-17 18:18:14 EST --- (In reply to comment #1) > Taking this as I maintain several ruby related packages > and oniguruma. > > Some notes: > > * Source tarball > - No tarball cannot be downloaded from the URL written as > SOURCE0 URL. > > Also, the tarball downloaded as > $ wget -O joni-1.1.3.tar.gz "http://github.com/jruby/joni/tarball/1.1.3"; > differs from the tarball in your srpm: > --------------------------------------------------------------------- > 120420 joni-1.1.3.tar.gz > 124045 joni-1.1.3-2.fc12.src/jruby-joni-bb99ccb.tar.gz > --------------------------------------------------------------------- Changed. The new url in the spec file should be the complete/final github url where the tarball is located. > > * Requires > - There is two "jpackage-utils" entry in Requires > > * linking > --------------------------------------------------------------------- > 56 ln -s %{_javadir}/%{name}-%{version}.jar > $RPM_BUILD_ROOT%{_javadir}/%{name}.jar > --------------------------------------------------------------------- > - The following line is sufficient. > --------------------------------------------------------------------- > ln -s %{name}-%{version}.jar $RPM_BUILD_ROOT%{_javadir}/%{name}.jar > --------------------------------------------------------------------- > Both done. > * Stripping binaries > - Don't strip binaries by yourself and create debuginfo rpm > correctly. Removed completely as the gcj aot bits are no longer needed / used in Fedora. > > * %check > - As this tarball contains test/ directory, it is preferable that > you add %check section and execute some test program there > (if possible, I am not familiar with java) Couldn't find the 'test' build target (ant test doesn't work), so leaving be for now unless this is a huge thing. > > By the way I would appreciate it if you would review my review > request (bug 565603) Looks like I just missed it, got approval this morning. Updated and uploaded new joni rpm Spec URL: http://mo.morsi.org/files/jruby/joni.spec SRPM URL: http://mo.morsi.org/files/jruby/joni-1.1.3-3.fc12.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review