Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=491497 --- Comment #25 from Christian Krause <chkr@xxxxxxxxxxx> 2010-02-17 18:03:31 EST --- (In reply to comment #24) > Spec URL: http://www.flyn.org/SRPMS/dmapd.spec > SRPM URL: http://www.flyn.org/SRPMS/dmapd-0.0.22-1.fc12.src.rpm Thanks for the new package. > - New upstream version (fixes "service dmapd stop") Very good - thank you very much. Starting, Restarting and Stopping of the daemon does now work as expected. > The issue regarding the "Unused metadata" message is partially fixed. This > particular message has been downgraded to a debug message, so you will not see > it unless the environment variable DMAPD_DEBUG is set. On the other hand, > different, less common messages still exist. This is more a problem with the > present limitations of the dmapd logging system than the package itself. > Luckily, I am the upstream maintainer and will fix this soon. However, I would Yes, I do still see lots of warnings if e.g. the files don't have correct id3 tags etc. > like to get dmapd accepted into Fedora as is because the software works > properly despite the logging issue. Yes, I agree with you - the logging issue will not block the review. I have re-checked all my comments and the package looks now quite good besides one issue I've just discovered (sorry I haven't recognized this earlier): Please enable the "User" config option by default in /etc/dmapd.conf: ------------------------ # User that dmapd will run as, current user if undefined: User=dmapd ------------------------ This will ensure that the daemon will run per default as the intended user "dmapd". Once you show me a new package with this change, the package will be approved. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review