Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=561482 Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |mtasaka@xxxxxxxxxxxxxxxxxxx Flag| |fedora-review? --- Comment #1 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2010-02-15 14:44:07 EST --- Taking this as I maintain several ruby related packages and oniguruma. Some notes: * Source tarball - No tarball cannot be downloaded from the URL written as SOURCE0 URL. Also, the tarball downloaded as $ wget -O joni-1.1.3.tar.gz "http://github.com/jruby/joni/tarball/1.1.3"; differs from the tarball in your srpm: --------------------------------------------------------------------- 120420 joni-1.1.3.tar.gz 124045 joni-1.1.3-2.fc12.src/jruby-joni-bb99ccb.tar.gz --------------------------------------------------------------------- * Requires - There is two "jpackage-utils" entry in Requires * linking --------------------------------------------------------------------- 56 ln -s %{_javadir}/%{name}-%{version}.jar $RPM_BUILD_ROOT%{_javadir}/%{name}.jar --------------------------------------------------------------------- - The following line is sufficient. --------------------------------------------------------------------- ln -s %{name}-%{version}.jar $RPM_BUILD_ROOT%{_javadir}/%{name}.jar --------------------------------------------------------------------- * Stripping binaries - Don't strip binaries by yourself and create debuginfo rpm correctly. * %check - As this tarball contains test/ directory, it is preferable that you add %check section and execute some test program there (if possible, I am not familiar with java) By the way I would appreciate it if you would review my review request (bug 565603) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review