Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=528782 Benjamin Otte <otte@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |otte@xxxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |otte@xxxxxxxxxx Flag| |fedora-review?, | |needinfo?(bnocera@xxxxxxxxx | |m) --- Comment #3 from Benjamin Otte <otte@xxxxxxxxxx> 2010-01-25 16:57:57 EST --- I'll review this one. Some comments: - I believe you should run update-gdk-pixbuf-loaders unconditionally in %postun. Only gtk shouldn't run it after uninstall, all other pixbuf loader providing packages do. - Is there a reason for not just running make install with the patch you included? - If you updated to git master, that patch would even be included already (hint hint) - I suppose Stephane doesn't want to make releases for this but rather wants to try to get it into gtk proper? So there's no use waiting for a release? I'll try to actually build it and run the checklist tomorrow -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review