[Bug 541535] Review Request: raul - Realtime Audio Utility Library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=541535

Michael Schwendt <mschwendt@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody@xxxxxxxxxxxxxxxxx    |mschwendt@xxxxxxxxx
               Flag|                            |fedora-review+

--- Comment #8 from Michael Schwendt <mschwendt@xxxxxxxxx> 2010-01-25 17:00:12 EST ---
* A plain rpmbuild shell function on a F-12 update-testing machine that only
adds stdin/stderr output logging. Somehow buildroot/builddir paths appeared in
the -debuginfo below /usr/src/debug. Though, I cannot reproduce it anymore. :-) 

* There is a mixture of $RPM_BUILD_ROOT and %buildroot in the spec.
https://fedoraproject.org/wiki/Packaging/Guidelines#macros

* x86_64 build hardcodes /usr/lib in raul.pc

* raul.pc is still somewhat "unclean" beyond that, which bears a risk that you
will have fun with it in the future: It hardcodes header/library search paths
instead of setting a dependency on "gthread-2.0" and "glib-2.0". It relinks
with gthread+glib2+rt, which libraul is linked with already.


* If you want me to give another update a look, feel free to request that.

If you think you can deal with those items in cvs: APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]