[Bug 528782] Review Request: xcf-pixbuf-loader - XCF (GIMP) image loader for GTK+ applications

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=528782

--- Comment #4 from Benjamin Otte <otte@xxxxxxxxxx> 2010-01-28 07:06:52 EST ---
Reviewed this. So the problems are:

- postun should run update-gdk-pixbuf-loaders unconditionally

- rpmlint:
$ rpmlint xcf-pixbuf-loader.spec 
xcf-pixbuf-loader.spec: W: mixed-use-of-spaces-and-tabs (spaces: line 19, tab:
line 1)
0 packages and 1 specfiles checked; 0 errors, 1 warnings.

- License says "LGPL" but should be "LGPLv2+"

- The correct static URL for the tarball is
http://gitorious.org/xcf-pixbuf-loader/mainline/archive-tarball/e5ce7614 (The
tarball is then generated and you need to redownload a minute or so later)

The rest is fine.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]