[Bug 557776] Review Request: libyubikey - Library for parsing / decrypting Yubikey passwords

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=557776

--- Comment #2 from Maxim Burgerhout <maxim@xxxxxxxxx> 2010-01-24 09:08:41 EST ---
Thanks for looking at this, Akio. I went over your notes:

1. Correct, but as modhex and ykdebug went to -devel, so did README (which is
about those two files for the largest part). So -devel now has a %doc section.
2. Fixed.
3. Looked into this. I redid the download so it's timestamp matches upstream.
However, the Makefile doesn't seem to handle INSTALLFLAGS or pass it to
install-sh, but the timestamps of installed files are intact, afaics. I don't
think the install part needs fixing. Please correct me if I'm wrong; I really
want to learn this. 
4. Fixed.
5. Moved them to -devel. I agree that is a better place for those binaries.
6. Fixed. Missed that.

New versions at:
http://dl.dropbox.com/u/284093/update-1/libyubikey.spec
http://dl.dropbox.com/u/284093/update-1/libyubikey-1.5-3.fc12.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]